chore: refresh QA dependencies and build setup#30
Conversation
|
検証結果を記録します。
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56e7aac901
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "start": "bash scripts/jekyll.sh serve", | ||
| "build": "bash scripts/jekyll.sh build", | ||
| "test": "npm run check:metadata && npm run lint && npm run check-links", | ||
| "test": "npm run check:security && npm run check:metadata && npm run lint && npm run check-links", |
There was a problem hiding this comment.
Keep the default test script runnable offline
In environments where the npm audit endpoint is blocked or unavailable, npm test now fails before running the metadata/lint/link checks; I reproduced this with npm test, which stopped at npm audit with a 403 from /-/npm/v1/security/advisories/bulk. Because this repo's existing checks otherwise avoid external network access (for example, external links are ignored by the link-check config), putting the registry-backed audit in the default test path breaks routine local/CI validation for network-restricted contributors even when the checked content is fine; consider keeping the audit as a separate CI/security step instead of gating npm test.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Refreshes the project’s QA/tooling dependencies and tightens the default CI/local quality gate by adding a security audit, while also aligning Markdown table formatting with newer markdownlint rules and improving local Jekyll build reliability.
Changes:
- Update Node QA devDependencies (
markdownlint-cli,markdown-link-check) and refreshpackage-lock.json. - Add
npm auditascheck:securityand include it in the defaultnpm testpipeline. - Improve local Jekyll build path by ensuring gems are installed when using host Bundler; update docs/CI and ignore generated Jekyll artifacts.
Reviewed changes
Copilot reviewed 4 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/jekyll.sh | Runs `bundle check |
| README.md | Updates local dev commands to npm ci, documents the expanded test pipeline, and adds check:security to the quality checks list. |
| package.json | Adds check:security (npm audit) and wires it into npm test; bumps QA tool versions. |
| package-lock.json | Lockfile refresh corresponding to updated QA dependencies and transitive updates. |
| docs/chapters/chapter-07/index.md | Normalizes Markdown table formatting (spacing/pipes) for lint compatibility. |
| docs/chapters/chapter-05/index.md | Normalizes Markdown table formatting (spacing/pipes) for lint compatibility. |
| docs/chapters/chapter-02/index.md | Normalizes Markdown table formatting (spacing/pipes) for lint compatibility. |
| docs/appendices/templates/triage-matrix/index.md | Normalizes Markdown table separator formatting. |
| docs/appendices/templates/pr/index.md | Normalizes Markdown table formatting used in the PR template. |
| .gitignore | Ignores additional local Jekyll/Bundler artifacts generated by build/test runs. |
| .github/workflows/ci.yml | Updates Actions Node setup step to actions/setup-node@v6. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
markdownlint-cli0.48.x /markdown-link-check3.14.x) and addnpm auditascheck:securityin the default test path.npm ci, verify Actionssetup-node@v6, and make the local Bundler path install missing gems before Jekyll build.Evidence
npm audit: 8 vulnerabilities (2 moderate, 6 high); after lockfile refresh: 0 vulnerabilities.actions/setup-node@v6and existingactions/checkout@v6tags are available upstream.scripts/jekyll.shnow runsbundle check || bundle installbeforebundle exec.Local verification
npm cinpm run check:securitynpm run check:metadatanpm run lintnpm run check-linksnpm testBUNDLE_PATH=/home/devuser/work/CodeX/booksB/.codex-local/tmp/issue-driven-bundle/path BUNDLE_APP_CONFIG=/home/devuser/work/CodeX/booksB/.codex-local/tmp/issue-driven-bundle/config npm run build_site/index.html,_site/chapters/chapter-01/index.html,_site/chapters/chapter-07/index.html,_site/appendices/templates/index.html.github/workflows/ci.ymlgit diff --check