Fix mobile sidebar visibility guard#223
Merged
ootakazuhiko merged 2 commits intoJun 7, 2026
Merged
Conversation
Collaborator
Author
|
@copilot review |
There was a problem hiding this comment.
Pull request overview
This PR hardens the mobile/tablet off-canvas sidebar “closed” behavior by ensuring the drawer is not only translated off-screen but also visibility: hidden after the slide-out completes, while keeping the opened state visible above the overlay and below the fixed header. The same guard is applied across the repository’s duplicated mobile-responsive.css files to keep behavior consistent.
Changes:
- Enforce closed drawer state with
transform: translateX(-100%) !importantplusvisibility: hiddenand a delayed visibility transition. - Ensure opened drawer is explicitly
visibility: visibleand uses a transform-only transition to avoid delayed showing. - Align z-index expectations (
z-index: 999 !important) to keep the drawer above the overlay (950) and below the header (1000) where documented.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| github-guide-for-beginners-book/docs/assets/css/mobile-responsive.css | Adds closed-state visibility guard + delayed visibility transition and mirrors opened-state visibility/transition. |
| docs/assets/css/mobile-responsive.css | Applies the same visibility/transition guard while preserving the existing z-index/transform “important” rationale comments. |
| assets/css/mobile-responsive.css | Mirrors the guard and ensures the opened transform is !important to reliably override the closed important transform. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@copilot review |
Copilot stopped work on behalf of
ootakazuhiko due to an error
June 7, 2026 11:36
ootakazuhiko
deleted the
codex/issue168-sidebar-visibility-followup-20260607
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visibility: hiddenand a delayed visibility transition.mobile-responsive.csscopy in this repository to avoid asset drift.Part of itdojp/it-engineer-knowledge-architecture#168.
Verification
git diff --checkz-index: 999 !important, closedtransform: translateX(-100%) !important, closedvisibility: hidden, delayed visibility transition, and openedvisibility: visible.