Skip to content

[codex] Refresh GitHub beginners QA dependencies#221

Merged
ootakazuhiko merged 1 commit into
mainfrom
codex/github-beginners-quality-sprint-20260604
Jun 4, 2026
Merged

[codex] Refresh GitHub beginners QA dependencies#221
ootakazuhiko merged 1 commit into
mainfrom
codex/github-beginners-quality-sprint-20260604

Conversation

@ootakazuhiko

Copy link
Copy Markdown
Collaborator

Summary

  • Refresh QA/deploy dev dependencies (markdownlint-cli, markdown-link-check, and gh-pages) and audit-fix package-lock.json.
  • Add a dependency audit step to Docs Quality Gate, include package-lock.json in its path trigger, and enable npm cache for root installs.
  • Normalize existing table delimiter rows required by newer markdownlint MD060 in docs/ and matching manuscript/ appendices.
  • Document Node.js 20.18.1+ / npm audit in README and ignore additional local Jekyll/Bundler/GitHub Pages artifacts.

Verification

  • npm ci
  • npm test
  • npm run docs:quality-gate
  • npm audit
  • Bundler install with workspace-local BUNDLE_PATH / BUNDLE_APP_CONFIG
  • bundle exec jekyll build --config docs/_config.yml --source docs --destination _site
  • Built-site smoke for top page, chapter Git basics, chapter GitHub Actions, shortcut appendix, and resources appendix
  • Workflow YAML parse for all .github/workflows/*.{yml,yaml}
  • git diff --check

Notes

  • Full npm audit improved from 10 vulnerabilities (4 moderate, 5 high, 1 critical) to 0.
  • Jekyll build still emits Sass deprecation warnings from the existing minima theme dependency, but the build succeeds and this PR does not change that theme stack.

Copilot AI review requested due to automatic review settings June 4, 2026 09:49

Copy link
Copy Markdown
Collaborator Author

@copilot review

このPRでは、QA/deploy devDependencies更新、npm audit 0件化、Docs Quality Gateへの監査追加、markdownlint MD060 に合わせた既存表区切り行の正規化、README/ignore整備を行っています。Jekyll build の Sass deprecation warning は既存 minima theme 由来で、ビルド自体は成功するため今回の修正対象外です。

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refreshes the repository’s Node-based QA/tooling dependencies and updates the Docs Quality Gate workflow to include dependency auditing, while also adjusting markdown tables in docs/manuscript to comply with newer markdownlint behavior and documenting the Node.js minimum required by transitive QA dependencies.

Changes:

  • Bump QA/dev dependencies (markdownlint-cli, markdown-link-check, gh-pages) and update package-lock.json accordingly.
  • Enhance .github/workflows/docs-quality-gate.yml with package-lock.json triggers, npm cache, and an npm audit step.
  • Update README and ignore rules, plus normalize table delimiter rows in docs/manuscript appendices for markdownlint.

Reviewed changes

Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Documents Node.js 20.18.1+ requirement and adds npm audit to the suggested verification commands.
package.json Updates QA/dev dependency versions.
package-lock.json Lockfile refresh reflecting dependency bumps and audit fixes.
manuscript/appendix-resources/index.md Normalizes markdown table delimiter rows for lint compatibility.
manuscript/appendix-github-shortcuts/index.md Normalizes markdown table delimiter rows for lint compatibility.
docs/appendices/appendix-resources/index.md Normalizes markdown table delimiter rows for lint compatibility.
docs/appendices/appendix-github-shortcuts/index.md Normalizes markdown table delimiter rows for lint compatibility.
.gitignore Ignores additional Jekyll/Bundler/GitHub Pages local artifacts.
.github/workflows/docs-quality-gate.yml Adds package-lock.json path triggers, enables npm cache, and runs npm audit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator Author

マージ前確認を完了しました。

ローカル検証:

  • npm ci
  • npm test
  • npm run docs:quality-gate
  • npm audit(0 vulnerabilities)
  • workspace-local Bundlerで bundle install
  • bundle exec jekyll build --config docs/_config.yml --source docs --destination _site
  • built-site smoke(top / Git basics / GitHub Actions / shortcut appendix / resources appendix)
  • workflow YAML parse
  • git diff --check

CI / Review:

  • PR head: 1e1fe6f6c2de1913f792a2e6507bbd1cb74c0ed1
  • Docs Forbidden Check 26944288514: success
  • Docs Quality Gate 26944288555: success
  • Book QA 26944288551: success
  • Copilot PR reviewer: review本文のみ、生成コメントなし
  • Copilot cloud agent: run 26944521932 success
  • pr-review-completeness: status=ok, reviews=1, review_comments=0, review_threads=0, unresolved_threads=0, generated_count_mismatches=0, missing_review_ids=0

備考:

  • npm audit は 10件(moderate 4 / high 5 / critical 1)から 0件へ改善しました。
  • Jekyll build の Sass deprecation warning は既存 minima theme stack 由来で、ビルドは成功しています。

@ootakazuhiko ootakazuhiko merged commit 45abce2 into main Jun 4, 2026
5 checks passed
@ootakazuhiko ootakazuhiko deleted the codex/github-beginners-quality-sprint-20260604 branch June 4, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants