Fix mobile sidebar visibility guard#30
Merged
ootakazuhiko merged 2 commits intoJun 7, 2026
Merged
Conversation
Collaborator
Author
|
@copilot review |
There was a problem hiding this comment.
Pull request overview
This PR tightens the mobile/tablet sidebar “closed” state so the off-canvas drawer can’t remain visually present (or stack incorrectly) due to later desktop sidebar rules in main.css.
Changes:
- Forces the mobile/tablet sidebar closed state to use
transform: translateX(-100%) !importantandvisibility: hiddenwith a delayed visibility transition. - Ensures the opened sidebar becomes
visibility: visibleand keeps its stacking above the overlay viaz-index: 999 !important.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Reviewed the current PR state. Local QA passed ( |
Collaborator
Author
|
@copilot review |
Copilot stopped work on behalf of
ootakazuhiko due to an error
June 7, 2026 11:36
ootakazuhiko
deleted the
codex/issue168-sidebar-visibility-followup-20260607
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visibility: hiddenand a delayed visibility transition.mobile-responsive.css, so the guard is applied only to that stylesheet.Part of itdojp/it-engineer-knowledge-architecture#168.
Verification
git diff --checkz-index: 999 !important, closedtransform: translateX(-100%) !important, closedvisibility: hidden, delayed visibility transition, and openedvisibility: visible.