Fix mobile sidebar visibility guard#171
Conversation
|
@copilot review |
|
📚 Preview DeploymentYour changes have been deployed to a preview environment: 🔗 Preview URL: https://itdojp.github.io/ai-testing-strategy-book/pr-preview/pr-171/ Preview Details
|
Reviewed the current PR state and reran light validation. No additional code changes are required at this time. |
There was a problem hiding this comment.
Pull request overview
This PR hardens the mobile/tablet off-canvas sidebar behavior by ensuring the closed state is not only translated off-screen, but also visibility: hidden (with a delayed visibility transition), while keeping the opened state visible and layered above the dimming overlay. The same guard is applied to both tracked copies of mobile-responsive.css in the repository.
Changes:
- Update the mobile/tablet
.book-sidebarclosed state to includevisibility: hiddenplus a delayed visibility transition alongside the existing off-canvas transform. - Ensure the opened (checked) sidebar explicitly restores
visibility: visiblewhile preserving the transform-based opening behavior. - Mirror the same CSS adjustments into the duplicated
mobile-responsive.csscopy.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/assets/css/mobile-responsive.css | Adds visibility + delayed transition to the closed mobile sidebar state; restores visibility when opened. |
| ai-testing-strategy-book/docs/assets/css/mobile-responsive.css | Mirrors the same mobile sidebar visibility/transition guard in the duplicated stylesheet copy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot review |
ootakazuhiko
deleted the
codex/issue168-sidebar-visibility-followup-20260607
branch
Summary
visibility: hiddenand a delayed visibility transition.mobile-responsive.csscopy in this repository to avoid asset drift.Part of itdojp/it-engineer-knowledge-architecture#168.
Verification
git diff --checkz-index: 999 !important, closedtransform: translateX(-100%) !important, closedvisibility: hidden, delayed visibility transition, and openedvisibility: visible.