Fix mobile sidebar visibility guard#134
Merged
ootakazuhiko merged 2 commits intoJun 7, 2026
Merged
Conversation
Collaborator
Author
|
@copilot review |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the mobile/tablet off-canvas sidebar CSS so the closed state is fully non-visible (not just translated off-screen), and so visibility changes are coordinated with the slide transition to avoid edge “peeking”/flash issues. The same guard is applied to both duplicated mobile-responsive.css copies in the repo.
Changes:
- Force the closed sidebar to
visibility: hiddenwith a delayed visibility transition that aligns with the transform animation. - Ensure the opened sidebar becomes immediately visible and stays stacked above the overlay by setting
z-indexwith!important. - Mirror the updates across the repository’s duplicated CSS files.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
IT-engineer-communication-book/docs/assets/css/mobile-responsive.css |
Adds a visibility guard + delayed visibility transition for the closed sidebar and ensures proper stacking above the overlay. |
docs/assets/css/mobile-responsive.css |
Mirrors the same sidebar visibility/transition/z-index guard changes for the duplicated stylesheet. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@copilot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visibility: hiddenand a delayed visibility transition.mobile-responsive.csscopy in this repository to avoid asset drift.Part of itdojp/it-engineer-knowledge-architecture#168.
Verification
git diff --checkz-index: 999 !important, closedtransform: translateX(-100%) !important, closedvisibility: hidden, delayed visibility transition, and openedvisibility: visible.