Skip to content

Fix mobile sidebar visibility guard#134

Merged
ootakazuhiko merged 2 commits into
mainfrom
codex/issue168-sidebar-visibility-followup-20260607
Jun 7, 2026
Merged

Fix mobile sidebar visibility guard#134
ootakazuhiko merged 2 commits into
mainfrom
codex/issue168-sidebar-visibility-followup-20260607

Conversation

@ootakazuhiko

@ootakazuhiko ootakazuhiko commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Reinforce the mobile/tablet sidebar closed state with visibility: hidden and a delayed visibility transition.
  • Keep the opened sidebar visible and above the overlay while preserving the existing off-canvas transform fix.
  • Apply the same guard to each tracked mobile-responsive.css copy in this repository to avoid asset drift.

Part of itdojp/it-engineer-knowledge-architecture#168.

Verification

  • git diff --check
  • Static CSS guard check for z-index: 999 !important, closed transform: translateX(-100%) !important, closed visibility: hidden, delayed visibility transition, and opened visibility: visible.

Copilot AI review requested due to automatic review settings June 7, 2026 11:19
@ootakazuhiko

Copy link
Copy Markdown
Collaborator Author

@copilot review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the mobile/tablet off-canvas sidebar CSS so the closed state is fully non-visible (not just translated off-screen), and so visibility changes are coordinated with the slide transition to avoid edge “peeking”/flash issues. The same guard is applied to both duplicated mobile-responsive.css copies in the repo.

Changes:

  • Force the closed sidebar to visibility: hidden with a delayed visibility transition that aligns with the transform animation.
  • Ensure the opened sidebar becomes immediately visible and stays stacked above the overlay by setting z-index with !important.
  • Mirror the updates across the repository’s duplicated CSS files.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
IT-engineer-communication-book/docs/assets/css/mobile-responsive.css Adds a visibility guard + delayed visibility transition for the closed sidebar and ensures proper stacking above the overlay.
docs/assets/css/mobile-responsive.css Mirrors the same sidebar visibility/transition/z-index guard changes for the duplicated stylesheet.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ootakazuhiko

Copy link
Copy Markdown
Collaborator Author

@copilot review

@ootakazuhiko ootakazuhiko merged commit 468a5b0 into main Jun 7, 2026
3 checks passed
@ootakazuhiko ootakazuhiko deleted the codex/issue168-sidebar-visibility-followup-20260607 branch June 7, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants