Skip to content

TALIE-1535: add orientation classification#19

Open
NastyBoget wants to merge 3 commits into
masterfrom
TALIE-1535_orientation_classifier
Open

TALIE-1535: add orientation classification#19
NastyBoget wants to merge 3 commits into
masterfrom
TALIE-1535_orientation_classifier

Conversation

@NastyBoget

Copy link
Copy Markdown
Collaborator

No description provided.

@NastyBoget NastyBoget requested a review from Travvy88 June 19, 2026 13:09
@NastyBoget NastyBoget self-assigned this Jun 19, 2026
@NastyBoget NastyBoget added the enhancement New feature or request label Jun 19, 2026
@NastyBoget NastyBoget force-pushed the TALIE-1535_orientation_classifier branch 4 times, most recently from c37cb0c to 468175d Compare June 19, 2026 13:27
@NastyBoget NastyBoget force-pushed the TALIE-1535_orientation_classifier branch 2 times, most recently from ff8839e to 4334237 Compare June 23, 2026 10:48
@NastyBoget NastyBoget force-pushed the TALIE-1535_orientation_classifier branch from 4334237 to 877ae0e Compare June 23, 2026 10:51
"""
super(ClassificationModelTorch, self).__init__()
self.efficientnet_b0 = models.efficientnet_b0(pretrained=model_path is None)
self.efficientnet_b0.classifier[1] = nn.Linear(in_features=1280, out_features=num_classes)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а тут в классификатор веса же не загружаются?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не загружаются, они загружаются в OrientationClassifier.
Если model_path не передавать, то будет загружаться pretrained-модель, это используется при обучении новой модели

"""
def __init__(self, model_path: Optional[str], num_classes: int = 6) -> None:
"""
first 2 classes mean columns number

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

если я правильно понял, тут mean используется в качестве означает? мб написать the first 2 classes are the number of columns или the first 2 classes contain the number of columns

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и для других все равно не оч множет быть понятно, поч распределение классов именно такое, мб добавить пояснялку типа [1 колонка, несколько колонок, 0, 90, 180, 270]

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

написала более подробный комментарий, и правда было не понятно

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants