Add sim app and snapshot rendering to agentic env gen browser gui#804
Draft
qianl-nv wants to merge 4 commits into
Draft
Add sim app and snapshot rendering to agentic env gen browser gui#804qianl-nv wants to merge 4 commits into
qianl-nv wants to merge 4 commits into
Conversation
Long-lived SimulationApp subprocess handles registry-backed validation and rendering without restarting Kit on each Streamlit interaction. Signed-off-by: Qian Lin <qianl@nvidia.com>
Render per-node PNG thumbnails from solved poses using a Kit-enabled SimulationApp and display them on the dashboard node cards. Signed-off-by: Qian Lin <qianl@nvidia.com>
Start the sidecar on demand, route registry validation through it, and refresh node-card thumbnails when YAML is edited or generated. Signed-off-by: Qian Lin <qianl@nvidia.com>
Let ArenaEnvInitialGraphSpec validate task and relation types without re-running registry lookups when the sidecar already owns asset resolution. Signed-off-by: Qian Lin <qianl@nvidia.com>
qianl-nv
commented
Jun 16, 2026
| def validate(self) -> Self: | ||
| def validate(self, info: ValidationInfo) -> Self: | ||
| """Check unique IDs, constraint references, and spatial constraint shapes.""" | ||
| if info.context and info.context.get("skip_registry"): |
Collaborator
Author
There was a problem hiding this comment.
benchmark how much this helps, remove them if the impact is small.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Short description of the change (max 50 chars)
Detailed description