feat(secrets): allow rules to not require a matching header#193
Open
drewstone wants to merge 1 commit into
Open
feat(secrets): allow rules to not require a matching header#193drewstone wants to merge 1 commit into
drewstone wants to merge 1 commit into
Conversation
Add a `require` flag (default true) to secret-injection rules so a rule can be configured non-required: when the configured match header is absent the request is allowed through untransformed instead of rejected. Needed for CONNECT/tunnelled flows that legitimately carry no matchable header. Includes unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
requireflag (default true, preserving current behaviour) to secret-injection rules. When a rule is configuredrequire: falseand its match header is absent, the request is passed through untransformed instead of rejected. Includes unit tests.Why
CONNECT / tunnelled flows legitimately carry no matchable header; a strict rule rejects them.
require: falselets such a rule apply when the header is present and otherwise step aside. Carried as a local patch in our sandbox-egress deployment; upstreaming to drop it.Compatibility
Default
require: trueis the existing behaviour — no change unless a rule opts in.