Add `BIOSSettingsSet` resource and controller#383

Merged

afritzler merged 17 commits into

mainfrom

Aug 13, 2025

nagadeesh-nagaraja commented Jun 27, 2025 •

edited

Loading

Contributor

Fixes #349


          Add resource and controller

a3da166

nagadeesh-nagaraja self-assigned this

github-project-automation Bot added this to Roadmap

github-actions Bot added size/XXL api-change documentation labels

hardikdr added the area/metal-automation label

nagadeesh-nagaraja commented

View reviewed changes

internal/controller/biossettingsset_controller.go Outdated

nagadeesh-nagaraja commented

View reviewed changes

internal/controller/biossettingsset_controller.go Outdated

nagadeesh-nagaraja commented

View reviewed changes

internal/controller/biossettingsset_controller.go

nagadeesh-nagaraja commented

View reviewed changes

internal/controller/biossettingsset_controller.go Outdated

nagadeesh-nagaraja commented

View reviewed changes

internal/controller/biossettingsset_controller.go Outdated

nagadeesh-nagaraja commented

View reviewed changes

internal/controller/biossettingsset_controller.go Outdated

nagadeesh-nagaraja commented

View reviewed changes

internal/controller/suite_test.go


          code improvements

7d3744f

nagadeesh-nagaraja requested a review from stefanhipfel

July 3, 2025 12:10

nagadeesh-nagaraja moved this to In Progress in Roadmap

nagadeesh-nagaraja marked this pull request as ready for review

July 7, 2025 10:37

nagadeesh-nagaraja requested review from Nuckal777, SzymonSAP, afritzler and defo89 and removed request for defo89

July 7, 2025 10:37


          reconcile when server is deleted or created

d303208

nagadeesh-nagaraja force-pushed the biosSettingSet branch from 8f187f5 to d303208 Compare

July 8, 2025 08:30

stefanhipfel reviewed

View reviewed changes

api/v1alpha1/biossettingsset_types.go Outdated

nagadeesh-nagaraja commented Jul 10, 2025

Contributor Author

moving to draft to wait for PR with biosSettingsFlow and BiosVersionSet to complete. this will help reduce double work :)

nagadeesh-nagaraja marked this pull request as draft

July 10, 2025 12:46

nagadeesh-nagaraja added 2 commits

July 24, 2025 16:04


          Merge remote-tracking branch 'origin/main' into biosSettingSet

d3ae5ab


          improvement based on other PR reviews

f207570

nagadeesh-nagaraja added 2 commits

July 24, 2025 17:18


           add more unit test

11f0350


          Changes related to PR 403

e5f6fae

nagadeesh-nagaraja requested a review from stefanhipfel

July 29, 2025 07:50


          Merge remote-tracking branch 'origin/main' into biosSettingSet

bbedf74

nagadeesh-nagaraja requested a review from defo89

July 29, 2025 07:59

nagadeesh-nagaraja marked this pull request as ready for review

July 29, 2025 08:06

nagadeesh-nagaraja force-pushed the biosSettingSet branch from 00d8b67 to b4ca700 Compare

July 29, 2025 10:28


          Stabilize unit tests in BIOS

f438617

nagadeesh-nagaraja force-pushed the biosSettingSet branch from b4ca700 to f438617 Compare

July 29, 2025 11:27

nagadeesh-nagaraja added 4 commits

August 5, 2025 11:04


          Add docs, fix role

e858301


          fix sample, json tag

97e1281


          Merge remote-tracking branch 'origin/main' into biosSettingSet

b727bd1


          fix printColumn

e1ecd17

Nuckal777 reviewed

View reviewed changes

Nuckal777 left a comment

Contributor

Thanks. 👍 Logic seems sound in general. This PR needs a rebase once #403 is in.

api/v1alpha1/biossettingsset_types.go Outdated

+              	BIOSSettingsTemplate BIOSSettingsTemplate `json:"biosSettingsTemplate,omitempty"`
+              	// ServerSelector specifies a label selector to identify the servers that are to be selected.
+              	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="ServerSelector is immutable"

Nuckal777 Aug 11, 2025

Contributor

Why is the serverSelector immutable here? This is not done for other Set types.

nagadeesh-nagaraja Aug 12, 2025 •

edited

Loading

Contributor Author

I realized that it might be good to restrict it? I will need to add it to others as well.
basically, if they change the selector, whole thing will work like newly created one anyway, because it will delete all current and create new one..

why not create new resource at first place?

let me know what you think?

afritzler Aug 13, 2025 •

edited

Loading

Member

Can't we just recalculate the dependencies and create/update/delete all child objects? What is the problem with that?

afritzler Aug 13, 2025

Member

But I guess we can fix that later.

docs/concepts/biossettingsset.md Outdated

internal/controller/biossettingsset_controller.go Outdated

internal/controller/biossettingsset_controller.go Outdated

internal/controller/biossettingsset_controller.go Outdated

internal/controller/biossettingsset_controller.go Outdated

internal/controller/biossettingsset_controller.go Outdated

nagadeesh-nagaraja commented Aug 12, 2025

Contributor Author

Thanks. 👍 Logic seems sound in general. This PR needs a rebase once #403 is in.

@Nuckal777 or we could merge this into #403's branch.. if this PR looks good, then merge all together to main.

nagadeesh-nagaraja requested a review from Nuckal777

August 12, 2025 08:07


          fix review comments

b753de8

nagadeesh-nagaraja force-pushed the biosSettingSet branch from 224cae9 to b753de8 Compare

August 12, 2025 09:50

nagadeesh-nagaraja added 2 commits

August 12, 2025 15:48


          Merge remote-tracking branch 'origin/main' into biosSettingSet

b3074c9


          Missed merge conflicts

16668ea

afritzler requested changes

View reviewed changes

afritzler left a comment

Member

Lgtm from my side. Just some minor cosmetics.

api/v1alpha1/biossettings_types.go Outdated

internal/controller/biossettings_controller.go Outdated


          Updated logs and comments

308c17f

nagadeesh-nagaraja requested a review from afritzler

August 12, 2025 16:18

Nuckal777 approved these changes

View reviewed changes

afritzler approved these changes

View reviewed changes

afritzler added the enhancement label

afritzler merged commit 33920c7 into main

16 checks passed

github-project-automation Bot moved this from In Progress to Done in Roadmap

afritzler deleted the biosSettingSet branch

August 13, 2025 05:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

+1 more reviewer

Labels

api-change area/metal-automation documentation enhancement size/XXL