Feature/rename dhcp ipv6#778
Merged
Merged
Conversation
added 2 commits
May 11, 2026 14:37
The own_ipv6 field in struct dp_iface_cfg was set in the ND neighbour solicitation handler but never read anywhere in the codebase. Remove the field and its only write site. Signed-off-by: Guvenc Gulce <guevenc.guelce@external.t-systems.com>
The field dhcp_ipv6 in struct dp_iface_cfg holds the VM's own IPv6 address, not something specific to DHCP. Rename it to own_ipv6 to better reflect its purpose. Signed-off-by: Guvenc Gulce <guevenc.guelce@external.t-systems.com>
peanball
approved these changes
May 13, 2026
Contributor
peanball
left a comment
peanball
left a comment
There was a problem hiding this comment.
Confirmed that the field own_ipv6 was never read and could not be read from outside. Renaming it looks safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply removes the unused
own_ipv6inipv6_nd_node.c(it was set and never used). Then it reuses the name for the originaldhcp_ipv6. This way the name is consistent with theuint32_t own_ipFixes #704