feat(hal): implement functions to normalize buffer references and buffer bindings to subspan buffers#24472
Open
schuermans-roofline wants to merge 1 commit into
Conversation
schuermans-roofline
force-pushed
the
buffer_ref_binding_normalize
branch
2 times, most recently
from
7d09d90 to
eb829f1
Compare
…fer bindings to subspan buffers Buffer references and bindings can point to subspans of buffers. HAL drivers need to handle this case and access the actual memory allocation in the underlying allocated buffer. This can be handled by normalizing buffer references and buffer bindings before processing those. Normalization means to replace the reference to (a part of) a subspan buffer with a reference to the corresponding part of the underlying allocated buffer in the buffer reference or buffer binding. This change provides functions that perform those normalizations as helpers/infrastructure for HAL drivers. Signed-off-by: Stefan Schuermans <schuermans@roofline.ai>
schuermans-roofline
force-pushed
the
buffer_ref_binding_normalize
branch
from
eb829f1 to
652923f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buffer references and bindings can point to subspans of buffers. HAL drivers need to handle this case and access the actual memory allocation in the underlying allocated buffer. This can be handled by normalizing buffer references and buffer bindings before processing those. Normalization means to replace the reference to (a part of) a subspan buffer with a reference to the corresponding part of the underlying allocated buffer in the buffer reference or buffer binding.
This change provides functions that perform those normalizations as helpers/infrastructure for HAL drivers.