store rewarding states to erigon db#4701
Closed
envestcc wants to merge 28 commits into
Closed
Conversation
CoderZhi
reviewed
Aug 21, 2025
envestcc
force-pushed
the
erigon-store-rewarding
branch
from
August 31, 2025 23:24
84ef284 to
839333f
Compare
envestcc
force-pushed
the
erigon-store-rewarding
branch
from
September 25, 2025 10:27
839333f to
e4235b1
Compare
envestcc
force-pushed
the
erigon-store-rewarding
branch
from
September 25, 2025 11:05
e4235b1 to
08cf2b9
Compare
|
CoderZhi
reviewed
Sep 25, 2025
Comment on lines
+27
to
+29
| type ObjectStorageRegistry struct { | ||
| contracts map[string]map[reflect.Type]int | ||
| } |
Collaborator
There was a problem hiding this comment.
in most of the cases, we don't really need reflect.Type to tell the contract index. maybe, we can have a fallback contract for those without a type:
contracts map[string]struct{
types map[reflect.Type]int
fallback int
}
Such that for Delete, we can have reflect.Type as an option.
Collaborator
There was a problem hiding this comment.
and we can delete all the registrations in rewarding protocol, and skip the registration type by type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
as title
base #4700
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: