Skip to content

multiple fixes for archive node#4698

Merged
envestcc merged 17 commits into
iotexproject:masterfrom
envestcc:erigon-archive
Aug 27, 2025
Merged

multiple fixes for archive node#4698
envestcc merged 17 commits into
iotexproject:masterfrom
envestcc:erigon-archive

Conversation

@envestcc

Copy link
Copy Markdown
Member

Description

This PR is intended to merge the final fixes from the archive into the master branch.

base #4690

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

Comment thread blockchain/blockchain.go
Comment on lines -403 to -404
bc.mu.RLock()
defer bc.mu.RUnlock()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the private function context doesn't rely on the lock, but is there any side effect?

@sonarqubecloud

Copy link
Copy Markdown

@envestcc
envestcc merged commit 8e678b7 into iotexproject:master Aug 27, 2025
4 checks passed
@envestcc
envestcc deleted the erigon-archive branch August 27, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants