multiple fixes for archive node#4698
Merged
Merged
Conversation
CoderZhi
reviewed
Aug 21, 2025
Comment on lines
-403
to
-404
| bc.mu.RLock() | ||
| defer bc.mu.RUnlock() |
Collaborator
There was a problem hiding this comment.
the private function context doesn't rely on the lock, but is there any side effect?
CoderZhi
approved these changes
Aug 26, 2025
envestcc
force-pushed
the
erigon-archive
branch
from
August 26, 2025 16:32
2d4d152 to
989210b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR is intended to merge the final fixes from the archive into the master branch.
base #4690
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: