Skip to content

[staking] build staking view from blockdao if indexer height behind#4658

Merged
envestcc merged 10 commits into
iotexproject:masterfrom
envestcc:viewbuilder
Aug 21, 2025
Merged

[staking] build staking view from blockdao if indexer height behind#4658
envestcc merged 10 commits into
iotexproject:masterfrom
envestcc:viewbuilder

Conversation

@envestcc

Copy link
Copy Markdown
Member

Description

base #4655

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@envestcc
envestcc marked this pull request as ready for review June 30, 2025 13:27
@envestcc
envestcc requested review from a team, CoderZhi, Liuhaai and dustinxie as code owners June 30, 2025 13:27
@sonarqubecloud

sonarqubecloud Bot commented Jul 1, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
7.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@envestcc envestcc added the bug Something isn't working label Jul 8, 2025
Comment thread action/protocol/staking/protocol.go
Comment thread action/protocol/staking/protocol.go Outdated
Comment thread action/protocol/staking/protocol.go Outdated
Comment thread action/protocol/staking/stakeview_builder.go Outdated
Comment thread blockindex/contractstaking/indexer.go Outdated
Comment thread action/protocol/staking/stakeview_builder.go Outdated
Comment thread action/protocol/staking/viewdata.go Outdated
Comment thread blockindex/contractstaking/indexer.go Outdated
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
7.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@envestcc
envestcc merged commit d25fdd8 into iotexproject:master Aug 21, 2025
3 of 4 checks passed
@envestcc
envestcc deleted the viewbuilder branch August 21, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants