fix: enable node-click highlighting in YAML editor mode#175
Open
sakshammjn wants to merge 3 commits into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where clicking a node in the graph visualization failed to highlight the corresponding lines in the Monaco editor when the editor format was set to YAML. The existing implementation used jsonc-parser (which only supports JSON) to resolve node paths to editor positions. This worked for JSON but failed for YAML, as
parseTreereturned undefined and the effect bailed out early.Changes:
useEffectinMonacoEditor.tsxto branch onschemaFormat: usingjsonc-parserfor JSON (unchanged) and yaml'sparseDocumentfor YAMLschemaFormatto theuseEffectdependency array to re-trigger highlights on format switchWhat kind of change does this PR introduce
Bug fix
Issue Number
Closes #167
Video
Screen.Recording.2026-03-10.at.10.51.11.PM.mov
Does this PR introduce a breaking change?
No
If relevant, did you update the documentation?
No