Skip to content

Allow overriding inviwo/inviwo checkout ref without modifying the workflow#280

Merged
petersteneteg merged 6 commits into
masterfrom
copilot/add-inviwo-ref-input
Apr 2, 2026
Merged

Allow overriding inviwo/inviwo checkout ref without modifying the workflow#280
petersteneteg merged 6 commits into
masterfrom
copilot/add-inviwo-ref-input

Conversation

Copilot AI commented Apr 1, 2026 •
edited by petersteneteg
Loading

Copy link
Copy Markdown
Contributor

Adds option to specify which inviwo ref to use with a comment

Copilot AI changed the title [WIP] Add inviwos ref input for dynamic branch cloning Allow overriding inviwo/inviwo checkout ref without modifying the workflow Apr 1, 2026
Copilot AI requested a review from petersteneteg April 1, 2026 12:33
@petersteneteg

petersteneteg commented Apr 1, 2026

Copy link
Copy Markdown
Member

@copilot pls address the CI issues

@petersteneteg
Fix grep -oP to portable grep -oE for macOS compatibility
b6950b9 
Agent-Logs-Url: https://github.com/inviwo/modules/sessions/a50c328b-f21a-4a0b-9b48-ca60ec10d4a6

Co-authored-by: petersteneteg <3638222+petersteneteg@users.noreply.github.com>

Copilot AI commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

@copilot pls address the CI issues

Fixed in b6950b9. The grep -oP (Perl regex) flag isn't available on macOS (BSD grep), which would cause failures in the build (macOS matrix) and regression (macOS runner) jobs. Replaced with a portable grep -oE '/inviwo-ref \S+' | sed 's|/inviwo-ref ||' pipeline that works on both Linux and macOS.

@petersteneteg
petersteneteg marked this pull request as ready for review April 1, 2026 13:17
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

github-actions[bot]
github-actions Bot previously approved these changes Apr 1, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.1

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

martinfalk
martinfalk requested changes Apr 1, 2026
View reviewed changes
Comment thread .github/workflows/modules.yml Outdated
@github-actions
github-actions Bot dismissed their stale review April 1, 2026 17:15

outdated suggestion

github-actions[bot]
github-actions Bot previously approved these changes Apr 1, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.1

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

@petersteneteg

petersteneteg commented Apr 2, 2026

Copy link
Copy Markdown
Member

@copilot there is some CI issue when we don't hava a /inviwo-ref set

Copilot AI commented Apr 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot there is some CI issue when we don't hava a /inviwo-ref set

Fixed in 8c7bdf5. The shell runs with set -e -o pipefail, so when grep -oE finds no /inviwo-ref token in the PR body it exits with code 1, which caused the whole step to fail. Added || true to all three occurrences so a no-match is handled gracefully and falls through to the master default.

@github-actions
github-actions Bot dismissed their stale review April 2, 2026 06:44

outdated suggestion

github-actions[bot]
github-actions Bot approved these changes Apr 2, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.1

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

@petersteneteg
petersteneteg merged commit 604b1de into master Apr 2, 2026
34 of 35 checks passed
@petersteneteg
petersteneteg deleted the copilot/add-inviwo-ref-input branch April 2, 2026 16:40
github-actions Bot pushed a commit to inviwo/regression that referenced this pull request Apr 2, 2026
@Inviwo-Team
Remove regression reports for MERGED PR inviwo/modules#280
035e205
martinfalk pushed a commit that referenced this pull request Apr 9, 2026
@petersteneteg @martinfalk
Merge pull request #280 from inviwo/copilot/add-inviwo-ref-input
2671916 
Allow overriding inviwo/inviwo checkout ref without modifying the workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinfalk martinfalk martinfalk approved these changes
@github-actions github-actions[bot] github-actions[bot] approved these changes
@petersteneteg petersteneteg Awaiting requested review from petersteneteg

Assignees

@petersteneteg petersteneteg

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@petersteneteg @martinfalk