Skip to content

Added extraction modules and option to extract page ranges#9

Merged
yashlamba merged 7 commits into
mainfrom
extraction-tools
Mar 12, 2026
Merged

Added extraction modules and option to extract page ranges#9
yashlamba merged 7 commits into
mainfrom
extraction-tools

Conversation

@juliehinge

Copy link
Copy Markdown
Collaborator

❤️ Thank you for your contribution!

Partially addresses #4

Description

  • Added extraction tools (pdfplumber and pymupdf) as modules to pass to the activity
  • Added option to extract certain pages from pdfs.

@yashlamba yashlamba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we implement a base class for the extractors, so that we have some consistent interface, and when we implement a serializer for the API, it's easier?

Comment thread app/extractors/pymupdf_extractor.py Outdated
Comment thread app/extractors/pymupdf_extractor.py Outdated
Comment thread app/extractors/pymupdf_extractor.py Outdated
Comment thread app/routers/workflows.py Outdated
Comment thread app/routers/workflows.py Outdated
Comment thread app/routers/workflows.py Outdated
Comment thread app/extractors/base.py

@mairasalazar mairasalazar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, if it makes sense

Comment thread app/extractors/base.py Outdated
Comment thread app/extractors/pdfplumber_extractor.py Outdated
Comment thread app/activities/extract_pdf_content.py Outdated
Comment thread app/activities/extract_pdf_content.py Outdated
Comment thread app/extractors/pymupdf.py Outdated
Comment thread app/extractors/utils.py Outdated
@juliehinge
juliehinge requested a review from yashlamba March 9, 2026 14:57

@yashlamba yashlamba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, then should be good to merge

Comment thread app/extractors/pdfplumber.py
@yashlamba
yashlamba requested a review from OliverGeneser March 11, 2026 12:56
Comment thread app/extractors/utils.py
Comment thread app/extractors/__init__.py Outdated
Comment thread app/extractors/pymupdf.py Outdated
@yashlamba
yashlamba merged commit 0543191 into main Mar 12, 2026
2 checks passed
@yashlamba
yashlamba deleted the extraction-tools branch March 17, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants