Helm charts cleanup#82
Open
slint wants to merge 3 commits into
Open
Conversation
Migrations now finish before the app and worker pods start serving. A fresh install therefore needs a pre-existing DB secret (secrets.db.existingSecret), since the chart-managed db-secrets does not exist yet during the pre-install hook.
ttlSecondsAfterFinished let the TTL controller reap failed Jobs and their logs. Cleanup is left to the hook-delete-policy, which retains a failed Job until the next install or upgrade.
slint
force-pushed
the
helm-chart-cleanup
branch
from
b9ad88c to
10b94ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(helm): extract shared db and langfuse env helpers
fix(helm): run migrations on pre-install
Migrations now finish before the app and worker pods start serving. A fresh install therefore needs a pre-existing DB secret (secrets.db.existingSecret), since the chart-managed db-secrets does not exist yet during the pre-install hook.
fix(helm): keep failed migration job logs by dropping the TTL
ttlSecondsAfterFinished let the TTL controller reap failed Jobs and their logs. Cleanup is left to the hook-delete-policy, which retains a failed Job until the next install or upgrade.