feat(tracing): add langfuse tracing#77
Open
yashlamba wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Right now, we are explicitly propagating workflow context. 2 important problems to be fixed:
The custom
propagatecontext manager exists to avoid awkward inline imports in the activities. This can be used anywhere. The reason we need it is that we are passing activities around, and the way Temporal sandboxes worker code, langfuse imports don't work (Will open an issue explaining this in detail). The solution to this is to separate activity context/schemas and call them by "name", which Temporal supports.Add maybe a decorator/tracing indicator on activities, so this explicit propagation isn't needed. It is not very clean with how Temporal initialises activities, but we can try.