allow overriding ElasticsearchWriter for those who want a non restrictive https mode#80
Open
zg2pro wants to merge 3 commits into
Open
allow overriding ElasticsearchWriter for those who want a non restrictive https mode#80zg2pro wants to merge 3 commits into
zg2pro wants to merge 3 commits into
Conversation
zg2pro
changed the title
zg2pro
changed the title
zg2pro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Currently it's hard to make elasticsearch-appender work with https. Of course there is always the solution to register certificates into jvm but it's not handy especially if you have certificates with only 1 year validity, then you'd need many things to manage. If you let this method protected, people can override this method, override the ElasticsearchWriter, so when they want to trust all certificates, they can do it.
Best regards