Repository navigation
Conversation
whois_records.name in the WHOIS database had only a regular index, and all write paths did find-then-insert, so concurrent updates could insert two rows for one name. Later updates and deletes touched only one of them, leaving stale data in WHOIS. - Make the name index unique in whois_schema.rb - Add Whois::Record.find_or_create_by_name! and .save_by_name, which fall back to the existing row when a concurrent insert wins, and use them in all write paths - Add whois:remove_orphans rake task to list (and with DRY_RUN=false delete) WHOIS server records that have no source in Registry The unique index has to be applied to existing WHOIS databases manually after removing duplicate rows, there are no migrations for that database. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mmeest
approved these changes
Oct 2, 2026
OlegPhenomenon
approved these changes
Oct 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whois_records.name in the WHOIS database had only a regular index, and all write paths did find-then-insert, so concurrent updates could insert two rows for one name. Later updates and deletes touched only one of them, leaving stale data in WHOIS.
The unique index has to be applied to existing WHOIS databases manually after removing duplicate rows, there are no migrations for that database.