chore: build and push Docker image#60
Conversation
|
@adrianhopebailie can do that for you @wilsonianb. I think we do have it already setup for some other repos already. Would it not make more sense for the main moneyd repo to have a docker container and then pass options/arguments in for the specific uplinks? Put differently, why would the uplink need its own docker image? |
Moneyd would need to be packaged with all the uplinks for that to work |
sharafian
left a comment
There was a problem hiding this comment.
@adrianhopebailie can you add the credentials for this to circle? then it can be merged
|
At Matt's suggestion, I'm going to try having Dockerhub handle the image building. |
|
TIL you can't reopen a pull request if you've force pushed since closing it |
|
I've created a Dockerhub repo and configured it to autobuild and publish images for master and tags.
Would including moneyd and the uplinks in the interledgerjs monorepo make that possible? |
This would require us to add interledgerjs(?) docker hub account credentials to circleci