Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 30 additions & 12 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ dependencies = [
"httpx (>=0.28.1,<0.29.0)",
"pydantic (>=2.10.6,<3.0.0)",
"cryptography (>=45.0.4,<46.0.0)",
"http-message-signatures (>=0.6.1,<0.7.0)"
"http-message-signatures (>=0.6.1,<0.7.0)",
"http-sf (>=1.0.4,<1.1.0)"
]

[build-system]
Expand Down
3 changes: 2 additions & 1 deletion src/open_payments_sdk/gnap_utils/security.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from typing import Sequence
from http_message_signatures import HTTPMessageSigner, algorithms
import http_sfv
from http_sf import ser
from httpx import Request
from open_payments_sdk.gnap_utils.hash import HashManager
from open_payments_sdk.gnap_utils.http_signatures import OPKeyResolver, PatchedHTTPSignatureComponentResolver
Expand Down Expand Up @@ -49,6 +50,6 @@ def set_content_digest(self, request: Request) -> Request:
"""
Compute Digest
"""
request.headers["Content-Digest"] = str(http_sfv.Dictionary({"sha-512": hashlib.sha512(request.content).digest()}))
request.headers["Content-Digest"] = ser({"sha-512": hashlib.sha512(request.content).digest()})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since even the http_message_signatures lib doesn't use http_sf this, this can be simplified to one less dependency with:

digest = hashlib.sha512(request.content).digest()
request.headers["Content-Digest"] = f"sha-512=:{base64.b64encode(digest).decode('ascii')}:"

return request