Potential fix for code scanning alert no. 48: Wrong type of arguments to formatting function#500
Draft
bgotowal wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 48: Wrong type of arguments to formatting function#500bgotowal wants to merge 1 commit into
bgotowal wants to merge 1 commit into
Conversation
… to formatting function Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses code-scanning alert #48 by making the printf-style precision argument for "%.*s" type-correct in the libcurl response header callback, avoiding varargs undefined behavior while preserving existing logging behavior.
Changes:
- Added
<climits>to accessINT_MAX. - Introduced a bounded
int(logLen) derived fromnumbytes(asize_t) and used it as the"%.*s"precision argument innetwork_log_message_aux.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/intel/confidential-computing.tee.dcap/security/code-scanning/48
Use a correctly typed precision argument for
"%.*s"by convertingnumbytes(size_t) tointonly after bounding it toINT_MAX. This keeps behavior the same (log up to full header line) while removing undefined behavior from varargs mismatch.Best fix in this file/region:
tools/SGXPlatformRegistration/src/network/src/MPSynchronicSender.cppinresponseHeaderCallBackaround line 83.<climits>include (forINT_MAX).numbytesin the log call with a boundedintlocal variable, e.g.:int logLen = (numbytes > static_cast<size_t>(INT_MAX)) ? INT_MAX : static_cast<int>(numbytes);network_log_message_aux(..., "%.*s", logLen, b);No functional behavior change beyond making the formatting call type-safe in all builds.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.