Skip to content

feat(apps): Make auth_token optional to promote public keys - #474

Merged
kofrezo merged 7 commits into
mainfrom
dk_optional_auth_token
Oct 12, 2026
Merged

kofrezo merged 7 commits into
mainfrom
dk_optional_auth_token

Conversation

@kofrezo

@kofrezo kofrezo commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Nudge users to use public keys instead of auth tokens by removing the default token generation

@kofrezo
kofrezo requested a review from brainexe September 26, 2026 10:29
@kofrezo kofrezo self-assigned this Sep 26, 2026
@kofrezo
kofrezo requested a review from raimund-s September 28, 2026 07:46
@brainexe

brainexe commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

the createapp command does not generate a token anymore, as createapp still assumes pre_save generates a token, which this MR removes:
reproduce:

createapp --non-interactive
# resulting app: auth_token=None app_id=None public_keys=0

Suggestion: either generate a token in createapp when none is given, or fail on an empty token. Either way, the Token (empty for auto generated one) prompt needs updating

@kofrezo

kofrezo commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

the createapp command does not generate a token anymore, as createapp still assumes pre_save generates a token, which this MR removes: reproduce:

createapp --non-interactive
# resulting app: auth_token=None app_id=None public_keys=0

Suggestion: either generate a token in createapp when none is given, or fail on an empty token. Either way, the Token (empty for auto generated one) prompt needs updating

This is fine. This is only used on the development setup locally to setup a test user and app and this is setting the environment variables properly.

@kofrezo
kofrezo force-pushed the dk_optional_auth_token branch from b23da5e to 5bfa92d Compare October 12, 2026 14:22
@kofrezo

kofrezo commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

the createapp command does not generate a token anymore, as createapp still assumes pre_save generates a token, which this MR removes: reproduce:

createapp --non-interactive
# resulting app: auth_token=None app_id=None public_keys=0

Suggestion: either generate a token in createapp when none is given, or fail on an empty token. Either way, the Token (empty for auto generated one) prompt needs updating

This is fine. This is only used on the development setup locally to setup a test user and app and this is setting the environment variables properly.

I added some more changes and included the change now.

@kofrezo
kofrezo merged commit a76fe55 into main Oct 12, 2026
5 checks passed
@kofrezo
kofrezo deleted the dk_optional_auth_token branch October 12, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants