Drop PHP <8.4, upgrade to kohana-view 5.x #17
Merged
Conversation
acoulton
force-pushed
the
feat-kohana-view-5
branch
from
fea7635 to
7ec06e2
Compare
craig410
approved these changes
Nov 4, 2025
craig410
left a comment
craig410
left a comment
Member
There was a problem hiding this comment.
Looks fine, just query that removed parent constructor call
| public function __construct( | ||
| protected readonly ContentSnippetRepository $snippets_repo | ||
| ) { | ||
| parent::__construct(); |
Member
There was a problem hiding this comment.
Intentionally not calling the parent constructor?
Member
Author
There was a problem hiding this comment.
There's no longer a __construct on AbstractViewModel (as we only had it to compile the expected display variables etc and now that's not required so it was empty).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.