[FIX] account_statement_import_sheet_file_bg: handle OpenPyXL Cell values in sheet header parsing#396
Closed
fw-bot-adhoc wants to merge 1 commit into
Closed
Conversation
…lues in sheet header parsing Prevent crash when importing XLSX files where header rows are iterated as OpenPyXL Cell objects instead of plain strings. add parser override in miscellaneous module to normalize header values support both raw strings and Cell instances before calling strip keep OCA module untouched as required preserve existing behavior for CSV/XLS flows Fixes: AttributeError: 'Cell' object has no attribute 'strip' Alternative (more concise) title: Fix: normalize XLSX header cells before strip in bg statement import X-original-commit: 09812b6
Contributor
|
|
Contributor
Author
|
@rov-adhoc @maq-adhoc this PR targets 19.0 and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Contributor
|
@roboadhoc r+ nobump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent crash when importing XLSX files where header rows are iterated as OpenPyXL Cell objects instead of plain strings.
add parser override in miscellaneous module to normalize header values support both raw strings and Cell instances before calling strip keep OCA module untouched as required
preserve existing behavior for CSV/XLS flows
Fixes:
AttributeError: 'Cell' object has no attribute 'strip'
Alternative (more concise) title:
fix: normalize XLSX header cells before strip in bg statement import
Forward-Port-Of: #395