Add release notes to GH releases#581
Conversation
Copied from grafana/helm-charts@98f267b
Copied from grafana/helm-charts@8d26baa
d2ff8b8 to
75cfaf3
Compare
|
helm 3.12.2 is out can maybe upgrade to latest. https://github.com/helm/helm/releases I don't think helm upgraded is required tho, as you prefer. |
powersj
left a comment
There was a problem hiding this comment.
No opposed, but can the cr.yaml file live under the .github/workflows directory as well?
|
Isn't .github/workflows reserved for github workflows? doesn't seem like the right place. There is already a ct.yaml (used by chart-testing) in root so this would go next to it. Actually seems like cr.yaml in current directory is loaded by default so |
This file is referenced by the github workflow, hence why I thought it should be in there. And avoids adding a file to the root of the project. This is not something I would expect someone to run by hand right? |
|
chart-releaser runs great locally from CLI but you probably wouldn't except for debug/setup. I'm not sure adding new .yaml files to .github/workflows will interfere with GitHub Actions? I'm happy to make the change if wanted tho... |
I noticed grafana/helm-charts repo has started to include changelog on releases and would really like to see the same in this repo!
Test release with changelog in my forked repo: https://github.com/morganchristiansson/influxdata-charts/releases/tag/telegraf-1.8.34
Changes copied from commit: grafana/helm-charts@98f267b
Also upgraded helm version - copied from this commit grafana/helm-charts@8d26baa