Skip to content

FI-3645 MS tests#25

Closed
360dgries wants to merge 10 commits into
mainfrom
FI-3645-MS-tests
Closed

FI-3645 MS tests#25
360dgries wants to merge 10 commits into
mainfrom
FI-3645-MS-tests

Conversation

@360dgries

Copy link
Copy Markdown
Contributor

Summary

Adds groups and MS tests to the SHC test kit for each of the AD profiles

Immunization AD profile does not seem to be specific to SHC -- please confirm that I've named it and respective files accordingly.

Added scratch storage in the existing validation test -- I see it doesn't have a case for covid19 specifically -- but the profiles have the same MS supports, so maybe it's unnecessary? Regardless, Covid19 resources are not stored in scratch yet.

It uses the regular method of pulling resources that match the profile from scratch and searching each of them to span the MS elements.

I added a spec test with a pass and a skip case for a complete and incomplete covid19 bundle. Can add more tests if needed.

Question for Reviewer:
I've added every MS test to each SHC group so that they can be ran within the same run as the bundle retrieval/validation. This is in order to maintain scratch, which is cleared after each Run.

@360dgries 360dgries requested a review from yunwwang February 27, 2025 16:33
@360dgries

Copy link
Copy Markdown
Contributor Author

I am having trouble with the updated IG package -- my windows machine cannot seem to unzip it correctly due to faulty headers. If I unzip it using something like tar, it gives some errors similar to this https://superuser.com/questions/318809/linux-os-x-tar-incompatibility-tarballs-created-on-os-x-give-errors-when-unt

That being said, the running the generator WILL disrupt the test kit, as much of this was organized manually -- I also made my own package that has all of the data minimization profiles removed for generation purposes, but haven't included it in this push

let(:request_repo) { Inferno::Repositories::Requests.new }
let(:group) { suite.groups.first.groups.find { |g| g.id.include?('shc_vaccination-Group01-shc_must_support_group')} }

def run(runnable, inputs = {})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge this we need to factor out the methods that are now auto-injected from inferno core. See inferno_core/spec/runnable_context.rb

@Shaumik-Ashraf

Copy link
Copy Markdown
Contributor

I'm closing this because the RSpecs are incompatible; we can reopen it if there is interest in the MS tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants