Remove tgz files from gem package#119
Merged
Merged
Conversation
karlnaden
requested changes
May 4, 2026
jlduran
force-pushed
the
remove-tar-artifacts
branch
from
cafd029 to
165e8ac
Compare
karlnaden
requested changes
May 5, 2026
karlnaden
left a comment
karlnaden
left a comment
Contributor
There was a problem hiding this comment.
small last cleanup, then will get merged in and released - thanks
The directory lib/fhir_models/igs contains core.tgz files, which increase the gem size considerably and are not required for normal operation. Remove the entire igs directory.
jlduran
force-pushed
the
remove-tar-artifacts
branch
from
165e8ac to
a03ae81
Compare
karlnaden
approved these changes
May 5, 2026
Contributor
Author
|
Thank you @karlnaden. I've applied your suggestions and submitted a few additional PRs. I'd appreciate it if you could take a look at those as well when you have a moment. |
Contributor
This one is merged. Will try to review the additional PRs later this week and get a gem out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a considerable file size increase for 5.0.0:
5.0.0 - October 14, 2024 (36.7 MB)
4.3.0 - May 30, 2024 (7.51 MB)
Mainly due to the inclusion of compressed artifacts:
Avoid it by excluding these files from the final gem package.