Use Inferno Validator Public Functions only#27
Merged
Conversation
karlnaden
approved these changes
Mar 5, 2026
karlnaden
requested changes
Mar 5, 2026
|
|
||
| # Only need to know if the resource is valid. | ||
| # Calling resource_is_valid? causes validation errors to be logged. | ||
| validator = find_validator(:default) |
Contributor
There was a problem hiding this comment.
You don't have to get the validator, you can use the resource_is_valid? DSL method directly
resource_is_valid?(resource:, profile_url: target_profile, add_messages_to_runnable: false)
See the US Core version: https://github.com/inferno-framework/us-core-test-kit/blob/main/lib/us_core_test_kit/reference_resolution_test.rb#L170
karlnaden
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the reference resolution test to use the public validator service functions, rather than calling the private functions directly. Should result in no change in behavior
For proof see the following two screenshots of a validation test performing identically in both production and locally (after changes):