FI-4144: Requirements Conversion#45
Merged
Merged
Conversation
tstrass
force-pushed
the
fi-4144-requirements-conversion
branch
from
556f732 to
8361d1b
Compare
Contributor
|
FYI - I added changes for FI-4156 (hrex requirements approach update) to this PR. |
karlnaden
requested changes
Jun 19, 2025
karlnaden
left a comment
karlnaden
left a comment
Contributor
There was a problem hiding this comment.
we have a few pending core changes to fix the ci workflow and a few other things that will require some slight changes - hoping that core update gets released today.
Contributor
Updates released! Remaining steps:
|
karlnaden
requested changes
Jun 26, 2025
karlnaden
approved these changes
Jul 2, 2025
karlnaden
requested changes
Jul 2, 2025
| spec.add_dependency 'udap_security_test_kit', '~> 0.11.4' | ||
| spec.add_dependency 'inferno_core', '~> 0.6.15' | ||
| spec.add_dependency 'smart_app_launch_test_kit', '~> 0.6.4' | ||
| spec.add_dependency 'subscriptions_test_kit', '~> 0.11.2' |
Contributor
There was a problem hiding this comment.
Update to
- 0.11.3 subscription dependency
- 0.6.16 core dependency
karlnaden
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update requirements to use the core tools.
This included removing a
verifies_requirementsthat seemed to be wrong and had no correct replacement as far as I could tell.There is a warning coming from the requirements coverage check which indicates that there are two requirements from subscriptions that should not be in the server suite (24, 86). This should go away once inferno-framework/subscriptions-test-kit#29 is merged and released.Testing Guidance
bundle exec inferno requirements checkand make sure it indicates the file is up to datebundle exec inferno requirements check_coverageand make sure it indicates that both files are up to date