Add BETA_PASSWORD support for private Steam beta branches#12
Open
indifferentketchup wants to merge 1 commit into
Open
Add BETA_PASSWORD support for private Steam beta branches#12indifferentketchup wants to merge 1 commit into
indifferentketchup wants to merge 1 commit into
Conversation
| export BETA_PASSWORD_ARG | ||
| # shellcheck disable=SC2016 # envsubst's varlist must be single-quoted. | ||
| envsubst '${BETA} ${BETA_PASSWORD_ARG}' < /home/steam/server/install.scmd \ | ||
| | tr -s ' ' \ |
Collaborator
There was a problem hiding this comment.
Is there any reason we can't simply add:
export BETA_PASSWORD="${BETA_PASSWORD}"?
Then continue our existing envsubst pattern.
| PASSIVE_MOBS=false | ||
| NO_BUILD_COST=false | ||
| BETA=public | ||
| BETA_PASSWORD= |
Collaborator
There was a problem hiding this comment.
Should default to yesimadebackups
| BEPINEXPACK_VERSION=5.4.2333 \ | ||
| BETA=public | ||
| BETA=public \ | ||
| BETA_PASSWORD= |
Collaborator
There was a problem hiding this comment.
Should default to yesimadebackups
| | NO_BUILD_COST | Disables building cost. | false | | ||
| | BEPINEX_ENABLED | Enables BepInEx modding. | false | | ||
| | BETA | Specifies a Steam beta branch to install (e.g., default_old). Set to public for stable branch. | public | | ||
| | BETA_PASSWORD | Password for private Steam beta branches (e.g., `yesimadebackups` for `public-test`). Leave blank for public branches. **Stored in plaintext in `.env` — treat the host accordingly.** | | |
Collaborator
There was a problem hiding this comment.
Include default value here
When BETA=public-test, install() appends -betapassword yesimadebackups to the steamcmd app_update args. Hardcoding the (publicly-known) password avoids a per-host env var.
indifferentketchup
force-pushed
the
betapassword
branch
from
d7799f7 to
18eb00c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BETA_PASSWORD env var for private Steam beta branches.
scripts/functions.sh: build BETA_PASSWORD_ARG in install(), add varlist to envsubst, pipe through tr -s ' '.
scripts/install.scmd: add ${BETA_PASSWORD_ARG} to the app_update line.
.env.example: add BETA_PASSWORD= (empty default).
docker-compose.yml: add BETA_PASSWORD: ${BETA_PASSWORD} to environment.
README.md: document BETA_PASSWORD in the env-vars table.