fix: ensure FactoryServer.sh is executable after installation#13
Open
Yakrel wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens container startup by ensuring the Satisfactory server launcher script (FactoryServer.sh) is executable after DepotDownloader installs/updates the server, preventing startup failures on certain filesystems/user-namespace setups (e.g., unprivileged LXC with ZFS).
Changes:
- Add a
chmod +x /satisfactory/FactoryServer.shstep inscripts/init.shafter installation/ownership adjustments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that
FactoryServer.shhas execute permissions (+x) set after installation, before the container attempts to runstart.sh.Context & Cause
This issue was encountered while deploying the server inside an unprivileged LXC container (running Docker) on Proxmox VE. The container consistently crashed with:
bash: line 1: ./FactoryServer.sh: Permission deniedThe root cause is that under unprivileged user namespaces and specific ZFS/mount policies,
DepotDownloader(.NET Core) cannot natively write/set the Unix execution permissions (+x) on downloaded files. Becauseinit.shandstart.shdo not explicitly runchmod +xon the newly downloadedFactoryServer.shscript, the container fails to launch the server.Solution
Adding
chmod +x /satisfactory/FactoryServer.shinscripts/init.shright after theinstallprocess and ownership fix resolves the issue. This ensures the script is executable across all host directory mounts and container runtimes, making the image more robust.