Repository navigation
ILLDEV-540 Add placeholder caching - #78
Merged
Merged
Conversation
JanisSaldabols
requested review from
adamdickmeiss,
ihardy,
jakub-id,
kurtnordstrom and
skomorokh
as code owners
October 13, 2026 13:10
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The unrelated translation removal causes a German localization regression.
1 open finding
What changed in this PR
Adds caching for broker-provided template placeholders.
Changes:
- Caches placeholders for eight hours with 30-minute freshness.
- Tests cache reuse and refetching.
- Removes German placeholder translations.
| File | Description |
|---|---|
TemplateForm.js |
Configures placeholder caching. |
TemplateForm.test.js |
Tests cache timing behavior. |
de.json |
Removes placeholder translations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
skomorokh
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.