Adds a talkbox setting to the microphone instrument#4513
Open
VeeNomine wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
S: Needs Review
S: Untriaged
size/XS
Changes: No C#
Changes: Upstream
and removed
size/XS
labels
…ffects unit. Since a talkbox is an effect rather than an actual instrument, this is the best creative commons soundfont I can find. Added the effect to the microphone instrument under the name "Talkbox". Tested it solo and with various electronic and percussion instruments. It passed. Attributed in the impstation.sf2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Adds a talkbox-esque soundfont to the microphone as a setting options.
Why / Balance
For fun. More instruments and soundfonts gives players more options for expression.
Technical details
Added the the talkbox sample, instrument, and preset to impstation.sf2, originally called "Wah" at source. Additionally, added attribution to impstation.sf2 under the general information section. Edited instruments_percussion.yml to include "Talkbox" as a swappable instrument.
Media
Talk.Box.without.DAW.mp4
Talk.Box.with.DAW.mp4
Requirements
Licensing
Changelog