fix: handle client certificates#13
Merged
Merged
Conversation
mertalev
force-pushed
the
fix/handle-client-cert
branch
from
5fab6b0 to
4d92b86
Compare
mertalev
force-pushed
the
fix/handle-client-cert
branch
2 times, most recently
from
8340e30 to
0a80cd0
Compare
alextran1502
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a localhost proxy backed by a shared URLSession. It uses a task-level delegate which allows auth challenges and such to be handled by the session-level delegate. The choice of a proxy is because using an AVAssetResourceLoaderDelegate means needing to implement an HLS client for HLS compatibility while a proxy can be dumb and let AVPlayer handle everything.
The
sessiondetermines whether it's used, and this in turn is set in the main app when the session gets a client auth or basic auth challenge. This means the change has no effect for most users. There is a smaller change on how video info is fetched, which helps to avoid UI stutters as the calls no longer block the thread.