Staff Page#123
Conversation
…hub.io into yl6/staff-page
…98vr.github.io into yl6/staff-page
…-cs498vr.github.io into yl6/staff-page
yl6
requested review from
ShanTulshi,
andrewipark,
cynthialiu208,
jasmineyshih,
mlally,
tojason and
zmabry2
| <img class="thumb" id="pokemon" frameborder="0"></img> | ||
| {% endif %} | ||
| <div class="text-wrapper"> | ||
| <a class="title" href="mailto:{{ person.email }}"> |
There was a problem hiding this comment.
Should we have a mail 📧 icon indicating that the name is clickable and leads to their email?
There was a problem hiding this comment.
I personally feel like it's pretty obvious that the names are clickable?
|
|
||
| .desc { | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; |
There was a problem hiding this comment.
Should we hide the overflow at all? Given that users will have no way of seeing the expanded text
Edit: This should probably be in _sass/vrsite/staff.scss, not here.
There was a problem hiding this comment.
I changed overflow to scroll and so now the description for each person doesn't have character limits and the text is scrollable to read.
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Let's aim to separate out the gallery as its own feature and apply it here and on the projects page. (#93) That way, we can minimize the amount of duplicated CSS. For now, can we move the duplicate CSS as an include? Any variations between the two implementations can be referenced as variables.
| image: https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/44.png | ||
| desc: | | ||
| description for person 1 | ||
| --- |
There was a problem hiding this comment.
Are we moving staff descriptions from individual files to one big YAML? I don't remember, but I would be in support of such a move.
There was a problem hiding this comment.
Yes we are! I'll work on it.
2 participants
The staff page is currently done similarly to the projects page. We can probably(...should definitely) use YAML instead of markdown.