Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Apply #356's calendar boundary policy to
packDateValues(), the remaining component-based sibling. LibXL packs 1899-12-31 as serial 1 (1900-01-01), while early dates in the 1904 system produce negative or time-only serials.Validation
PHP 8.4.26 NTS / LibXL 5.2.0.1, direct strict GCC build, zero warnings:
excel.c:3568,year < 1900→year < 1;excel.c:3587, removing the calendardt < 1condition and retaining onlydt == -1.Sibling sweep: shared
_php_excel_date_packalready guards timestamp packing and single/bulk AS_DATE writes; explicit time-only packing and unpacking remain unchanged. Unreleased Fixed follows #356; no released sections or generated arginfo changed.Local skips include licensed-only, optional benchmark, ZTS and Windows coverage; hosted CI now also passed its phpize/configure and multi-version LibXL lanes. New test is discovered by native Tests and Windows PHPT lanes.
CI: all 37 applicable jobs passed on exact head
16a45214032925be323a1cdc74f726f65d94d4b9: 15 Tests jobs (run 44329610907), 21 Windows jobs (run 44329610842), and Changelog guard (run 44329610847). Release attachment and peer recheck were conditionally skipped, not counted as passes.