Skip to content

feat(argocd-apps): add rawDirectory flag to opt out of helm rendering #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yreinhar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(argocd-apps): add rawDirectory flag to opt out of helm rendering #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions charts/argocd-apps/templates/application.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ spec:
path: {{ $project.git.path | default $projectName }}
repoURL: {{ $project.git.repoUrl }}
targetRevision: {{ $project.git.branch | default "main" }}
{{- if $project.git.rawDirectory }}

@hoeftale hoeftale Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do not need specific directory settings there is no need to set the directory directive explictily. "recurse: false" is the default.
If you need directory settings, please support setting these via values, e.g. $project.directorySettings

If you do not need for directory settings, it would be enough to omit the helm directive below. In this case please guard the .helm directive via "if $project.tofuValues"

@hoeftale hoeftale Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argo docs: https://argo-cd.readthedocs.io/en/stable/user-guide/directory/#directory

directory:
recurse: false
{{- else }}
helm:
values: |
{{- $project.tofuValues | toYaml | nindent 10}}
Expand All @@ -31,5 +35,6 @@ spec:
{{- if ((($project.tofuValues).projectValues).stage) }}
- values-{{ $project.tofuValues.projectValues.stage }}.yaml
{{- end }}
{{- end }}
---
{{- end }}
1 change: 1 addition & 0 deletions charts/argocd-apps/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ projects: {}
# secretStoreName: "" # Name of the secret store object created in K8s
# accessType: "" # Options: https or ssh
# secretPath: "" # Path to the secret in the targeted Hashicorp Vault
# rawDirectory: false # Optional, defaults to false. Set to true for plain Kubernetes YAML sources (e.g. ApplicationSets) to opt out of Helm rendering.

# # helm registries credentials
# helmRegistries:
Expand Down
Loading