[FEAT] Start implementing tests#459
Open
illia-prokopchuk wants to merge 2 commits into
Open
Conversation
muli-cohen
requested changes
Dec 9, 2025
muli-cohen
left a comment
muli-cohen
left a comment
Contributor
There was a problem hiding this comment.
Very nice written tests overall.
Take a look at Snapshot Testing for a sometimes great min effort: high value ratio.
muli-cohen
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Started implementing tests
🛠️ Changes Made
Added Vitest
Added tests for some common components
✅ Checklist
🔗 References
🚨 Potentially Breaking Changes
🔍 Additional Notes
FYI: It creates some cansole waring due to React.forwardRef
I don't want to add it, because we have a plat to move to React 19, where forwardRef is deprecated
📸 Screenshots / Demos