[#11] Frontend API integration#123
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Integrates the Angular audit dashboard with Query Service list/detail endpoints and the integrity-check API, adding typed models, pagination, loading/error states, and blockchain verification details.
Changes:
- Added API models and service methods for paginated audit logs, log details, and integrity checks.
- Updated the dashboard to load live data, paginate results, retry failures, and show blockchain verification in the drawer.
- Expanded unit tests for service and dashboard behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/audit-ui/src/app/models/audit-log.model.ts | Adds blockchain/integrity response models and pagination/date filter fields. |
| frontend/audit-ui/src/app/services/audit-log.service.ts | Adds detail and integrity-check requests and forwards additional query parameters. |
| frontend/audit-ui/src/app/services/audit-log.service.spec.ts | Extends HTTP service coverage for filters, detail lookup, and integrity checks. |
| frontend/audit-ui/src/app/features/audit-dashboard/audit-dashboard.component.ts | Adds pagination state, retry handling, destroy cleanup, and integrity-check loading. |
| frontend/audit-ui/src/app/features/audit-dashboard/audit-dashboard.component.html | Renders live table states, paginator, hash tooltips, and blockchain drawer details. |
| frontend/audit-ui/src/app/features/audit-dashboard/audit-dashboard.component.scss | Adds styles for loading, errors, no-data state, details, and hash/blockchain display. |
| frontend/audit-ui/src/app/features/audit-dashboard/audit-dashboard.component.spec.ts | Expands component tests for loading, errors, filters, pagination, details, and parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…able fallbacks, info tooltip
This was
linked to
issues
May 17, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (1)
frontend/audit-ui/src/app/features/audit-dashboard/audit-dashboard.component.scss:124
- The green text/background combination for
ON_CHAINhas insufficient contrast for the 12px chip text (roughly below the 4.5:1 WCAG AA threshold). Use a darker foreground or different background so the status remains readable for low-vision users.
.status-chip--on_chain {
background: #e6f4ea;
color: #1e8e3e;
}
…ignment - Remove role=status from integrity status chip (no live-region for static cells) - Replace info button (no action) with role=button span + stopPropagation - Add aria-label to page-level and drawer integrity progress bars - Add showFirstLastButtons to mat-paginator - Darken PENDING chip text #b06000 -> #7a4200 for WCAG 4.5:1 contrast - Do NOT update rowIntegrityById to UNKNOWN on transport failure (drawer error message is sufficient; list status must not be overwritten) - Update 2 specs to match: preserve original list status on integrity error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrates Angular UI with Query Service and Integrity Check APIs for issue #11.
Closes
Subtasks completed
getAuditLogs(pagination),getAuditLogById,checkIntegrityBlockchainRecord,IntegrityCheckResponse, extendedAuditLogFilters(limit,offset,from,to)MatPaginator(10/20/50, offset-based)Related
Main changes
frontend/audit-ui/src/app/models/audit-log.model.tsBlockchainRecordandIntegrityCheckResponseAuditLogFilterswith pagination/time filtersfrontend/audit-ui/src/app/services/audit-log.service.tsgetAuditLogById(id)checkIntegrity(id)getAuditLogsnow passes all filter params including paginationfrontend/audit-ui/src/app/features/audit-dashboard/audit-dashboard.component.tspageSize,pageIndex,estimatedTotal)integrityLoading,integrityCheckResult,integrityCheckError)onPageChange,retry, and proper teardown viangOnDestroy+takeUntilfrontend/audit-ui/src/app/features/audit-dashboard/audit-dashboard.component.htmlfrontend/audit-ui/src/app/features/audit-dashboard/audit-dashboard.component.scssTesting
Result:
TOTAL: 34 SUCCESSChecklist
asusage in@else iftakeUntilapplied for teardown safety