V2.5.0i#123
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Lighthouse testing configurability and improves perceived performance by adding Contentful image resizing parameters and adjusting image sizing behavior in UI components.
Changes:
- Made Lighthouse test target configurable via
SITE_URLand added additional skip guards for missing audits/categories. - Added Contentful
w/hquery params generation for images (BaseImage + Gallery) and introduced asizesoverride prop forBaseImage. - Adjusted article thumbnail sizing to cap requested dimensions and set an explicit
sizesattribute.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/lighthouse.test.mjs | Adds SITE_URL support and modifies Chrome launch flags/error handling for Lighthouse runs. |
| src/components/image/baseImage.jsx | Adds Contentful resizing params and sizes override; changes how NextImage props are constructed. |
| src/components/gallery/gallery.jsx | Adds Contentful resizing params for gallery images and computes a default sizes string. |
| src/components/article/article.jsx | Caps thumbnail dimensions and adds a sizes attribute for responsive behavior. |
| readme.md | Documents how to run Lighthouse tests with an override URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Create src/helpers/contentful.js with addContentfulParams and addBlurDataURL - Update all imports to use the consolidated helper
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Add format and quality params to addContentfulParams - Export addContentfulParams as named export
- Test format parameter (f=webp, f=png) - Test quality parameter (q=80, q=85, q=90) - Test both format and quality together - Test existing query params preservation - Test empty/null value handling
Changed 'separator' from mutable variable to computed inline values in catch block fallback
…ality - Update expected params from f/q to fm/q (Contentful API change) - Default format is 'webp', quality is 30 per imageConfig - Fix hash fragment test to include default params
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Image Optimization
Lighthouse Test
process.env.SITE_URLif set, otherwise falls back tositeConfig.siteUrl(https://igorstar.com)Results
Commits