fix(frontend): support nested preview links#557
Open
dongmucat wants to merge 1 commit into
Open
Conversation
Signed-off-by: dongmucat <1127093059@qq.com>
ae08157 to
0134da7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
handlePackageMarkdownLinkClick(...)path inSkillDetailPagedocumentationPathfor overview links andpreviewNode?.pathfor links rendered insideFilePreviewDialogonLinkClickthroughFilePreviewDialogintoMarkdownRendererREADME.md -> docs/usage.md -> docs/nested.mdTesting
make typecheck-webmake lint-webmake test-backend-appcd web && npx -y node@20.19.0 ./node_modules/vitest/vitest.mjs runcd web && env -u http_proxy -u https_proxy -u HTTP_PROXY -u HTTPS_PROXY -u all_proxy -u ALL_PROXY pnpm exec playwright test e2e/skill-detail-relative-links.spec.tsValidation Notes
make test-frontendstill fails on the local default Nodev20.18.0because Vitest/jsdom hits the knownhtml-encoding-sniffer->@exodus/bytesESM mismatch; the full suite passes undernode@20.19.0make stagingcurrently fails in the web container startup path with/docker-entrypoint.d/20-envsubst-on-templates.sh: can't open /etc/nginx/templates/default.conf.template: Operation not permitted; this happened after backend image build and frontend static build succeededImpact