feat(cli): support anonymous public search and install#523
Conversation
|
复核结论:Approved,未发现阻塞问题。说明:当前 GitHub 凭证被判定为 PR 作者,平台不允许我设置正式 确认点:
验证:GitHub checks 当前全部通过,包括 DCO、license/cla、Docs Build、Server Unit Tests、Web Build And Test、CLI ubuntu/macos/windows、E2E (Real Services)。本地核对 非阻塞流程提示:Multica |
3150e0d to
cd4c3ce
Compare
|
复审结论:代码层面通过,未发现阻塞问题。 说明:当前 GitHub 凭证无法提交 formal approval(GitHub 返回 “Can not approve your own pull request”),因此以普通 PR 评论记录技术复审结论。 确认点:
验证: 备注:ISSUE-48 的聚焦手工复测截图仍作为并行 QA 门禁等待,不影响本次代码复审结论。 |
|
追加独立 code review 结论:✅ 通过,未发现必须修复项。已按 PR #523 最新提交 Checklist:
验证: |
|
复核结论:两条新增审查意见均成立。请在 #523 内修复,不要新开交付 PR,不要合并 main。 说明:当前 GitHub 凭证无法提交 formal Changes Requested(GitHub 返回 “Can not request changes on your own pull request”),因此以普通 PR 评论记录代码审查要求。 阻塞问题:
修复建议:
优化建议:
验证状态:当前 #523 head 仍为 |
|
复审结论:P2 / P3 均已关闭,未发现新的代码阻塞问题。 确认点:
我本地在 PR head
非代码门禁:当前 GitHub rollup 只显示 DCO/CLA 通过,完整 Server/CLI/E2E checks 还未出现在最新 head 上;同时 PR 当前 |
Signed-off-by: dongmucat <1127093059@qq.com>
Signed-off-by: dongmucat <1127093059@qq.com>
Signed-off-by: dongmucat <1127093059@qq.com>
Signed-off-by: dongmucat <1127093059@qq.com>
Signed-off-by: dongmucat <1127093059@qq.com>
Signed-off-by: dongmucat <1127093059@qq.com>
Refs: 25f57a32-5f1d-4d56-b6b7-9b6b7b868799 Signed-off-by: dongmucat <1127093059@qq.com>
76c6d70 to
cf22f56
Compare
|
复审结论:代码层面通过,未发现阻塞问题。 说明:当前 GitHub 凭证无法提交 formal approval(GitHub 返回 “Can not approve your own pull request”),因此以普通 PR 评论记录技术复审结论。 确认点:
验证:
未新开 PR,未合并 main。 |
Summary
This PR consolidates the CLI anonymous public access work into one delivery PR.
What changed:
searchandinstallfor public, visible, active skills whose latest version is installable.skillhub search --tokenand preserve the intended token precedence across CLI auth sources.search,resolve, anddownloadaround the same latest-version installability rules: latest must exist, be published, download-ready, not yanked, and not hidden/private/archived/unpublished.Prior PR Handling
This PR replaces the prior split PRs #511, #512, #514, and #515. Those PRs are closed and were not merged.
Verification
Local verification reported for this PR:
git diff --check origin/main...HEAD: passedmake cli-install: passedmake test-backend-app: passed, 535 tests / 0 failures / 0 errorsmake typecheck-cli: passedmake lint-cli: passedmake test-cli: passed, 329 tests / 0 failuresmake build-cli: passedAdditional gates completed:
Notes
origin/main.mainwas performed.