feat(cli,domain): support non-global namespace skill download#497
Merged
Conversation
|
|
Parse namespace from skill name using -- separator (e.g., astroclaw--api-gateway) so users don't need --namespace flag. Allow anonymous download for any PUBLIC skill regardless of namespace. CLI changes: - Add cli/src/shared/skill-name-parser.ts utility - Update install and remove commands to parse skill name argument - 10 unit tests covering edge cases Domain changes: - SkillDownloadService.isAnonymousDownloadAllowed: drop namespace type check, only require PUBLIC visibility - Update test to expect success for team-namespace public skill Synced from SAAS commit 26c67e3
XiaoSeS
force-pushed
the
feat/non-global-namespace-download
branch
from
d2872db to
3c40d48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--separator (e.g.,astroclaw--api-gateway)Why
Users had to use
--namespaceflag for non-global skills, and anonymous download was artificially restricted to global namespace only despite skills being marked PUBLIC.Usage
--namespaceflag still takes precedence when explicitly specified.Implementation
CLI changes
cli/src/shared/skill-name-parser.tsutilityinstallandremovecommands updated to parse skill name argumentBackend changes
SkillDownloadService.isAnonymousDownloadAllowed: drop namespace type check, require only PUBLIC visibilityNamespaceTypeimportTesting
✅ skillhub-domain compiles cleanly
✅ skill-name-parser test suite: 10/10 passed
Origin
Synced from SAAS commit 26c67e3
Fixes #490