Remove deprecated syntax in ConcreteThermalMoisture#322
Conversation
|
Job Precheck on b43b388 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
b43b388 to
17a30b8
Compare
lynnmunday
left a comment
There was a problem hiding this comment.
I only had a question but I approve
| _cement_mass = isParamValid("cement_mass") ? getParam<Real>("cement_mass") : 354.0; | ||
| _water_to_cement = | ||
| isParamValid("water_to_cement_ratio") ? getParam<Real>("water_to_cement_ratio") : 0.43; | ||
| _cement_type = isParamValid("cement_type") ? getParam<MooseEnum>("cement_type") : 0; |
There was a problem hiding this comment.
Do you still need to set or check all of these defaults for the moisture_diffusivity_models?
There was a problem hiding this comment.
Good point. The way the new syntax (which we've been using for a while) works, those are all effectively required parameters for whatever model you're using. We should at least capture these recommended values, maybe just as comments in the code, so we don't lose them.
closes #318