Markdownlint more rules vol6#3157
Open
mnocon wants to merge 2 commits into
Open
Conversation
mnocon
force-pushed
the
markdownlint-more-rules-vol6
branch
from
5ea308e to
95931dd
Compare
mnocon
force-pushed
the
markdownlint-more-rules-vol6
branch
from
95931dd to
7db38da
Compare
|
ibexa-workflow-automation-1
Bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
julitafalcondusza
left a comment
julitafalcondusza
left a comment
Contributor
There was a problem hiding this comment.
Please check my comments/
| |----|----|-----------| | ||
| |`headline` (optional)|string|if not specified, the header isn't rendered| | ||
| |`headline_items`|array| | ||
| |`headline_items`|array| | |
Contributor
There was a problem hiding this comment.
Not sure if it's good to have an empty value here, before in another tables we are using "-".
Just to consider.
| | |billingAddressLastName|Payer's last name|Doe| | ||
| | |billingAddressEmail|E-mail address|user@example.com| | ||
| | |billingAddressPhoneNumber|Phone number|123456789| | ||
| |Order processing|orderId|Order numerical ID|123| | |
Contributor
There was a problem hiding this comment.
Same comment here - maybe we should be consistent and use or empty space or "-".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rules added:
no-emphasis-as-heading: https://github.com/DavidAnson/markdownlint/blob/0213a0274dfeaac589af389f6c9bc9e821655810/doc/md036.mdtable-column-count: https://github.com/DavidAnson/markdownlint/blob/0213a0274dfeaac589af389f6c9bc9e821655810/doc/md056.mdFor
table-column-coun, I had to replace the usage of|symbol in tables - it should only mean "end of table cell", otherwise it's impossible to distinguish which one is which (and some tools fail on that - for example, it fixes the table issue detected in #3161 )