Skip to content

IBX-10978: Added tel/mailto options to urlType#106

Merged
alongosz merged 14 commits into
4.6from
ibx-10978-add-tel-mailto-to-urltype
Feb 18, 2026
Merged

IBX-10978: Added tel/mailto options to urlType#106
alongosz merged 14 commits into
4.6from
ibx-10978-add-tel-mailto-to-urltype

Conversation

@reithor

@reithor reithor commented Jan 13, 2026

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-10978

Related PRs:

Description:

PR disables Symfony's FixUrlProtocolListener and introduces a custom FixUrlProtocolListener.
Symfony's FixUrlProtocolListener considers URLs like tel:123456 (without //) as having no protocol.
Those URLs will wrongly be prefixed with http://.
(Technically URLs like tel:123456 are valid).

Own implementation fixes this behavior.
For now only tel and mailto are added as allowed scheme - further improvement could make this part more flexible via config,

Reference for URL syntax:
https://en.wikipedia.org/wiki/URL#Syntax

For QA:

Needs to be tested together with ibexa/admin-ui#1813

@reithor
reithor marked this pull request as ready for review January 13, 2026 19:31
@reithor
reithor requested a review from a team January 13, 2026 19:31
@reithor
reithor force-pushed the ibx-10978-add-tel-mailto-to-urltype branch from a7b72e4 to 12c8017 Compare January 14, 2026 08:49
@reithor reithor added the Bug Something isn't working label Jan 23, 2026
Comment thread src/lib/Form/EventSubscriber/FixUrlProtocolListener.php Outdated
Comment thread src/lib/Form/EventSubscriber/FixUrlProtocolListener.php Outdated
Comment thread src/lib/Form/Type/FieldType/UrlFieldType.php Outdated
@reithor
reithor requested a review from alongosz January 29, 2026 16:04
@reithor

reithor commented Jan 30, 2026

Copy link
Copy Markdown
Contributor Author

@alongosz :
just for the case that you want to discuss the topic in general (so decide if mailto/tel should be allowed or if you share the understanding that URLs should always have an authority) here are some sources:

https://www.rfc-editor.org/rfc/rfc1738
https://en.wikipedia.org/wiki/URL

https://url.spec.whatwg.org/#urls
https://developer.mozilla.org/en-US/docs/Learn_web_development/Howto/Web_mechanics/What_is_a_URL

@mateuszbieniek

Copy link
Copy Markdown
Contributor

Hi @alongosz any chances of moving forward with the review? :)

@alongosz alongosz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alongosz any chances of moving forward with the review? :)

Hi @mateuszbieniek and @reithor, my apologies, looks like I made final review remarks, but I never submitted them 🤦

Here are some last nitpicks:

Comment thread src/lib/Form/EventSubscriber/FixUrlProtocolListener.php Outdated
Comment thread src/lib/Form/EventSubscriber/FixUrlProtocolListener.php
@reithor
reithor requested a review from alongosz February 16, 2026 08:27
Comment thread src/lib/Form/EventSubscriber/FixUrlProtocolListener.php Outdated
@reithor
reithor force-pushed the ibx-10978-add-tel-mailto-to-urltype branch from 647a602 to 50e7bfd Compare February 16, 2026 11:11
Comment thread src/lib/Form/EventSubscriber/FixUrlProtocolListener.php Outdated
@reithor
reithor requested a review from Steveb-p February 16, 2026 14:40
@barbaragr barbaragr self-assigned this Feb 18, 2026
@barbaragr
barbaragr force-pushed the ibx-10978-add-tel-mailto-to-urltype branch from bec8232 to aec98f2 Compare February 18, 2026 08:14
@sonarqubecloud

Copy link
Copy Markdown

@alongosz
alongosz merged commit ab3a1f1 into 4.6 Feb 18, 2026
14 checks passed
@alongosz
alongosz deleted the ibx-10978-add-tel-mailto-to-urltype branch February 18, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants